backport: Change the default page size to 64KiB on Aarch64 Linux #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @ovr! It looks like this is your first PR to tikv/jemalloc 🎉 |
ovr
force-pushed
the
chore/backport-arm64-64kb-pages
branch
from
904dbaf to
41af38f
Compare
ovr
force-pushed
the
chore/backport-arm64-64kb-pages
branch
from
41af38f to
858c2cc
Compare
ovr
force-pushed
the
chore/backport-arm64-64kb-pages
branch
from
858c2cc to
3ed3a0f
Compare
This updates the configuration script to set the default page size to 64KiB on Aarch64 Linux. This is motivated by compatibility as a build configured for a 64KiB page will work on kernels that use the smaller 4KiB or 16KiB pages, whereas the reverse is not true. To make the configured page size setting more visible, the script now displays the page size when printing the configuration results. Users that want to override the page size in to choose a smaller value can still do so with the --with-lg-pagesize configuration option. Author: lexprfuncall <[email protected]> Signed-off-by: Dmitry Patsura <[email protected]>
ovr
force-pushed
the
chore/backport-arm64-64kb-pages
branch
from
3ed3a0f to
61db681
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Thanks for your jemallocator crate. We are using it at Cube, but it doesn't support arm64 os with large mem pages (64k).
refs cube-js/cube#10152
facebook jemalloc version already merged a fix for that in facebook@7dcdafe
So, i propouse to backport (cherry-pick) an original commit from facebook/jemalloc repo to fix that issue.
Thanks